fatedierandGitHub 93b52799bb fix(xlog): make Logger prefix updates safe for concurrent logging (#5586) ...

Logger kept its rendered prefix in a plain string field that was written by
AddPrefix, AppendPrefix and ResetPrefixes and read without synchronization by
Tracef, Spawn and the other logging methods. In frpc the race is reachable on
the service-level logger, which every component of a session shares through
its context: adding the run ID after a login writes the prefix while control,
proxy manager, connector and visitor goroutines keep logging through the same
logger, and a reload that creates proxies calls Spawn on it. A torn string
header can pair a nil data pointer with a non-zero length, and formatting such
a prefix can crash the process when the log call's level is enabled.

Serialize the writers with a per-Logger mutex and publish the rendered prefix
as an immutable string through an atomic pointer, so the log path takes no
lock. Spawn copies the parent prefix list under the same mutex, keeping
children independent snapshots. Logging output is unchanged.

2026-10-23 15:52:11 +08:00

..

ctx.go

rename models to pkg (#2005)

2020-09-23 13:49:14 +08:00

log_writer.go

refactor: clean up code (#5308)

2026-05-12 11:13:50 +08:00

xlog_concurrency_test.go

fix(xlog): make Logger prefix updates safe for concurrent logging (#5586)

2026-10-23 15:52:11 +08:00

xlog_test.go

log: improve prefix handling (#5489)

2026-08-12 23:56:00 +08:00

xlog.go

fix(xlog): make Logger prefix updates safe for concurrent logging (#5586)

2026-10-23 15:52:11 +08:00