forked from Mxmilu666/frp
fatedierandGitHub
93b52799bb
Logger kept its rendered prefix in a plain string field that was written by AddPrefix, AppendPrefix and ResetPrefixes and read without synchronization by Tracef, Spawn and the other logging methods. In frpc the race is reachable on the service-level logger, which every component of a session shares through its context: adding the run ID after a login writes the prefix while control, proxy manager, connector and visitor goroutines keep logging through the same logger, and a reload that creates proxies calls Spawn on it. A torn string header can pair a nil data pointer with a non-zero length, and formatting such a prefix can crash the process when the log call's level is enabled. Serialize the writers with a per-Logger mutex and publish the rendered prefix as an immutable string through an atomic pointer, so the log path takes no lock. Spawn copies the parent prefix list under the same mutex, keeping children independent snapshots. Logging output is unchanged.
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
// Copyright 2026 The frp Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package xlog
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
)
|
|
|
|
func TestLoggerConcurrentPrefixAccess(t *testing.T) {
|
|
captureLogs(t)
|
|
xl := New().AddPrefix(LogPrefix{Name: "runID", Value: "old-run"})
|
|
start := make(chan struct{})
|
|
var wg sync.WaitGroup
|
|
wg.Add(2)
|
|
go func() {
|
|
defer wg.Done()
|
|
<-start
|
|
xl.AddPrefix(LogPrefix{Name: "runID", Value: "new-run"})
|
|
xl.AppendPrefix("proxy")
|
|
xl.ResetPrefixes()
|
|
}()
|
|
go func() {
|
|
defer wg.Done()
|
|
<-start
|
|
xl.Spawn().Tracef("spawn")
|
|
xl.Errorf("error")
|
|
xl.Warnf("warn")
|
|
xl.Infof("info")
|
|
xl.Debugf("debug")
|
|
xl.Tracef("trace")
|
|
}()
|
|
close(start)
|
|
wg.Wait()
|
|
}
|