fatedier
c7ac12ea0f
server/group: refactor with shared abstractions and fix concurrency issues ( #5222 )
...
* server/group: refactor group package with shared abstractions and fix concurrency issues
Extract common patterns into reusable components:
- groupRegistry[G]: generic concurrent map for group lifecycle management
- baseGroup: shared plumbing for listener-based groups (TCP, HTTPS, TCPMux)
- Listener: unified virtual listener replacing 3 identical implementations
Fix concurrency issues:
- Stale-pointer race: isCurrent check + errGroupStale + controller retry loops
- Worker generation safety: pass realLn and acceptCh as params instead of reading mutable fields
- Connection leak: close conn on worker panic recovery path
- ABBA deadlock in HTTP UnRegister: consistent lock ordering (group.mu -> registry.mu)
- Round-robin overflow in HTTPGroup: use unsigned modulo
Add unit tests (17 tests) for registry, listener, and baseGroup.
Add TCPMux group load balancing e2e test.
* server/group: replace tautological assertion with require.NotPanics
* server/group: remove blank line between doc comment and type declaration
2026-03-08 18:57:21 +08:00
fatedier
f22f7d539c
server/group: fix port leak and incorrect Listen port in TCPGroup ( #5200 )
...
Fix two bugs in TCPGroup.Listen():
- Release acquired port when net.Listen fails to prevent port leak
- Use realPort instead of port for net.Listen to ensure consistency
between port manager records and actual listening port
2026-03-06 02:25:47 +08:00
fatedier
9d077b02cf
lint by golangci-lint ( #3080 )
2022-08-29 01:02:53 +08:00
fatedier
6194273615
use net.JoinHostPort instead of fmt.Sprintf ( #2791 )
2022-02-09 15:19:35 +08:00
fatedier
8b75b8b837
fix by golint ( #1822 )
2020-05-24 17:48:37 +08:00
fatedier
b3ed863021
support http load balancing
2019-07-31 00:41:58 +08:00
fatedier
08c17c3247
frpc: support health check
2018-12-07 18:40:17 +08:00
fatedier
495b577819
update group ci
2018-05-23 14:39:12 +08:00